[virt-tools-list] [virt-viewer][PATCH 4/5 v2] Do not wait for a guest that will never show up

[Jonathon Jongsma]

On Thu, 2015-03-26 at 16:35 +0100, Fabiano Fidêncio wrote:
> All the situations where virt_viewer_update_display() can fail are
> those when we won't be able to connect regardless of what changes on the
> remote host. So, propagate the error instead of keep waiting.
> 
> Related: rhbz#1085216
> ---
>  src/virt-viewer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/virt-viewer.c b/src/virt-viewer.c
> index 3a570bb..386cdcc 100644
> --- a/src/virt-viewer.c
> +++ b/src/virt-viewer.c
> @@ -775,7 +775,7 @@ virt_viewer_initial_connect(VirtViewerApp *app, GError **error)
>      }
>  
>      if (!virt_viewer_update_display(self, dom, &err))
> -        goto wait;
> +        goto cleanup;
>  
>      ret = VIRT_VIEWER_APP_CLASS(virt_viewer_parent_class)->initial_connect(app, &err);
>      if (ret || err)

ACK