[virt-tools-list] [virt-viewer 0/8 v4] Series of patches improving error reporting to the user

Fabiano Fidêncio fidencio at redhat.com
Fri Mar 27 16:21:50 UTC 2015


Changes since v3:
* Address Christophe's comments about:
  ** Do not create a local err variable
  ** Improve commit messages
  ** Simplyfing the update_display logic
* Address Jonathon's comments about:
  ** Chaning the return type of _create_session()
     to boolean, as by convention the functions that
     take GError parameters should return FALSE or NULL

Changes since v2:
* Address Jonathon's comments about:
  ** g_set_error/g_set_error_literal
  ** add a GError arg to _create_session()

Changes since v1:
* Address Christophe's comments about:
  ** not treating --direct as a special case

Fabiano Fidêncio (8):
  virt-viewer: Add a GError arg to extract_connect_info()
  virt-viewer: Add a GError arg to update_display()
  virt-viewer-app: Add a GError arg to create_session()
  virt-viewer-app: create_session() should return a boolean
  virt-viewer: Avoid simple_message_dialog() when errors can be
    propagated
  remote-viewer: Avoid simple_message_dialog() when errors can be
    propagated
  virt-viewer: Do not wait for a guest that will never show up
  virt-viewer: Make update_display() more readable

 src/remote-viewer.c   | 16 +++++-----------
 src/virt-viewer-app.c | 18 +++++++++++-------
 src/virt-viewer-app.h |  2 +-
 src/virt-viewer.c     | 45 ++++++++++++++++++++++++++++-----------------
 4 files changed, 45 insertions(+), 36 deletions(-)

-- 
2.3.3




More information about the virt-tools-list mailing list