[virt-tools-list] [PATCH virt-viewer] virt-viewer-app: Set hotkeys when app is constructed

Christophe Fergeau cfergeau at redhat.com
Mon Mar 30 10:30:16 UTC 2015


Hey,

For what it's worth, a bit more details in the log about what is causing
the bug/why this commit is fixing it would be useful. From a quick look,
this might be the call to virt_viewer_app_set_enable_accel() which will
be overridden during property settings? I'd need to test to be sure.
Or maybe I'm missing something obvious here :)

Christophe

On Sat, Mar 28, 2015 at 02:26:47PM +0100, Pavel Grunt wrote:
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1206106
> ---
>  src/virt-viewer-app.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index dd0361f..cfc62b1 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -1742,7 +1742,6 @@ virt_viewer_app_init(VirtViewerApp *self)
>      gtk_window_set_default_icon_name("virt-viewer");
>      virt_viewer_app_set_debug(opt_debug);
>      virt_viewer_app_set_fullscreen(self, opt_fullscreen);
> -    virt_viewer_app_set_hotkeys(self, opt_hotkeys);
>  
>      self->priv->displays = g_hash_table_new_full(g_direct_hash, g_direct_equal, NULL, g_object_unref);
>      self->priv->config = g_key_file_new();
> @@ -1833,6 +1832,7 @@ virt_viewer_app_constructed(GObject *object)
>      self->priv->main_notebook = GTK_WIDGET(virt_viewer_window_get_notebook(self->priv->main_window));
>  
>      virt_viewer_app_set_kiosk(self, opt_kiosk);
> +    virt_viewer_app_set_hotkeys(self, opt_hotkeys);
>      virt_viewer_window_set_zoom_level(self->priv->main_window, opt_zoom);
>  
>      virt_viewer_set_insert_smartcard_accel(self, GDK_F8, GDK_SHIFT_MASK);
> -- 
> 2.3.4
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20150330/13961663/attachment.sig>


More information about the virt-tools-list mailing list