[virt-tools-list] [virt-manager PATCH] ui: improve pause/resume tooltip

[Pavel Hrdina]

On Tue, Nov 10, 2015 at 04:23:35PM -0500, Cole Robinson wrote:
> On 11/09/2015 02:06 PM, Pavel Hrdina wrote:
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1238618
> > 
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> >  ui/details.ui | 2 +-
> >  ui/manager.ui | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ui/details.ui b/ui/details.ui
> > index 6edc0e4..99718d2 100644
> > --- a/ui/details.ui
> > +++ b/ui/details.ui
> > @@ -464,7 +464,7 @@
> >                    <object class="GtkToggleToolButton" id="control-pause">
> >                      <property name="visible">True</property>
> >                      <property name="can_focus">False</property>
> > -                    <property name="tooltip_text" translatable="yes">Pause the virtual machine</property>
> > +                    <property name="tooltip_text" translatable="yes">Pause/resume the virtual machine</property>
> >                      <property name="label" translatable="yes">Pause</property>
> >                      <property name="use_underline">True</property>
> >                      <property name="stock_id">gtk-media-pause</property>
> > diff --git a/ui/manager.ui b/ui/manager.ui
> > index 2f3d465..63a4794 100644
> > --- a/ui/manager.ui
> > +++ b/ui/manager.ui
> > @@ -340,7 +340,7 @@
> >                      <property name="visible">True</property>
> >                      <property name="can_focus">False</property>
> >                      <property name="has_tooltip">True</property>
> > -                    <property name="tooltip_text" translatable="yes">Pause the virtual machine</property>
> > +                    <property name="tooltip_text" translatable="yes">Pause/resume the virtual machine</property>
> >                      <property name="label" translatable="yes">_Pause</property>
> >                      <property name="use_underline">True</property>
> >                      <property name="stock_id">gtk-media-pause</property>
> > 
> 
> It's a bit more work, but I prefer this done in the code, so a different
> tooltip is set depending on if the VM is paused or not.
> details.py:refresh_vm_state and manager.py:update_current_selection
> 
> Thanks,
> Cole

Yes, that makes sense, I've just tried to avoid that solution :)

Pavel