[virt-tools-list] [virt-manager PATCH] virt-install: don't report missing console in extra-args for ppc64

[Pavel Hrdina]

On Wed, Nov 11, 2015 at 02:58:16PM -0500, Cole Robinson wrote:
> On 11/11/2015 08:17 AM, Pavel Hrdina wrote:
> > On Tue, Nov 10, 2015 at 04:20:51PM -0500, Cole Robinson wrote:
> >> On 11/09/2015 02:02 PM, Pavel Hrdina wrote:
> >>> Kernel for ppc64 automatically enables serial console, there is no need
> >>> to report any warning.
> >>>
> >>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1247434
> >>>
> >>> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> >>> ---
> >>>
> >>> Pushed as trivial.
> >>>
> >>>  virt-install | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/virt-install b/virt-install
> >>> index d509256..3656835 100755
> >>> --- a/virt-install
> >>> +++ b/virt-install
> >>> @@ -520,6 +520,8 @@ def _show_nographics_warnings(options, guest):
> >>>          console_type = serial_arm_arg
> >>>      if guest.get_devices("console")[0].target_type in ["virtio", "xen"]:
> >>>          console_type = hvc_arg
> >>> +    if guest.os.is_ppc64():
> >>> +        return
> >>>  
> >>>      if console_type in (options.extra_args or ""):
> >>>          return
> >>>
> >>
> >> I don't think this actually works as you expect, this check is done _after_
> >> the warning mentioned in the bug report. I think it should be moved near the
> >> top of the function, where the similar arm machvirt check is done
> >>
> >> - Cole
> > 
> > It works as I expected, the warning mentioned in the BZ was updated by
> > commit 601a82cb.  I don't want to return near the top of the function where is
> > that check for arm, because there is still another warning about "No --console
> > device added, ..." which should be printed if user explicitly disable console
> > for his guest using "--console none".
> > 
> 
> You're right, my mistake! Misread the error message in the bug report.
> 
> ACK to this, but it means I need to fix the arm check as well
> 
> - Cole
> 

Thanks

That's right, I didn't notice the arm condition at first and there is one more
thing that needs to be fixed, I'll push it in a minute.

Pavel