[virt-tools-list] [virt-manager PATCH 1/2] virt-install: warn user about missing console while installing on arm

Pavel Hrdina phrdina at redhat.com
Wed Nov 11 20:32:25 UTC 2015


Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---

Pushed as trivial.

 virt-install | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/virt-install b/virt-install
index 3656835..e465c46 100755
--- a/virt-install
+++ b/virt-install
@@ -488,10 +488,6 @@ def _show_nographics_warnings(options, guest):
         return
     if not options.autoconsole:
         return
-    if guest.os.is_arm_machvirt():
-        # Later arm kernels figure out console= automatically, so don't
-        # warn about it.
-        return
 
     if guest.installer.cdrom:
         logging.warn(_("CDROM media does not print to the text console "
@@ -520,7 +516,9 @@ def _show_nographics_warnings(options, guest):
         console_type = serial_arm_arg
     if guest.get_devices("console")[0].target_type in ["virtio", "xen"]:
         console_type = hvc_arg
-    if guest.os.is_ppc64():
+    if guest.os.is_ppc64() or guest.os.is_arm_machvirt():
+        # Later arm/ppc kernels figure out console= automatically, so don't
+        # warn about it.
         return
 
     if console_type in (options.extra_args or ""):
-- 
2.6.3




More information about the virt-tools-list mailing list