[virt-tools-list] [PATCH virt-viewer v2] Adapt to spice-gtk single-header include policy

Daniel P. Berrange berrange at redhat.com
Mon Oct 12 09:26:24 UTC 2015


On Fri, Oct 09, 2015 at 04:15:13PM -0500, Jonathon Jongsma wrote:
> Unfortunately, there was no single-header include for the GTK+ library
> until just recently (spice-client-gtk.h), so this requires bumping the
> spice-gtk version requirement to a unreleased git version.

IIUC this is going to prevent virt-viewer being built against existing
released of spice. I think this is a rather unpleasant API break for
SPICE to force on client programs.

I would really expect there to be several releases where SPICE provided
the new single-header that apps could use, while *also* allowing apps
to continue to include the more specific headers. ie, give apps some
grace time to switch over to the new style. Can you try and re-visit
this in SPICE first.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the virt-tools-list mailing list