[virt-tools-list] [PATCH] Added option to enable kvm_hidden feature in virt-install cmd-line

Abhijeet Kasurde akasurde at redhat.com
Tue Sep 8 07:34:47 UTC 2015


Signed-off-by: Abhijeet Kasurde <akasurde at redhat.com>
---
 man/virt-install.pod                    | 4 ++++
 tests/xmlparse-xml/change-guest-out.xml | 3 +++
 tests/xmlparse.py                       | 1 +
 virtinst/cli.py                         | 1 +
 virtinst/domainfeatures.py              | 1 +
 5 files changed, 10 insertions(+)

diff --git a/man/virt-install.pod b/man/virt-install.pod
index fd0b0ad..92739d6 100644
--- a/man/virt-install.pod
+++ b/man/virt-install.pod
@@ -246,6 +246,10 @@ Enable APIC PV EOI
 
 Enable hypver VAPIC, but disable spinlocks
 
+=item B<--features kvm_hidden=on>
+
+Allow the KVM hypervisor signature to be hidden from the guest
+
 =back
 
 Use --features=? to see a list of all available sub options. Complete details at L<http://libvirt.org/formatdomain.html#elementsFeatures>
diff --git a/tests/xmlparse-xml/change-guest-out.xml b/tests/xmlparse-xml/change-guest-out.xml
index 5fcfc88..77cccfb 100644
--- a/tests/xmlparse-xml/change-guest-out.xml
+++ b/tests/xmlparse-xml/change-guest-out.xml
@@ -21,6 +21,9 @@
     </hyperv>
     <vmport state="on"/>
     <viridian/>
+    <kvm>
+      <hidden state="on"/>
+    </kvm>
   </features>
   <numatune>
     <memory nodeset="2,4,6"/>
diff --git a/tests/xmlparse.py b/tests/xmlparse.py
index f134400..cbe0deb 100644
--- a/tests/xmlparse.py
+++ b/tests/xmlparse.py
@@ -169,6 +169,7 @@ class XMLParseTest(unittest.TestCase):
         check("hyperv_spinlocks", True, True)
         check("hyperv_spinlocks_retries", 12287, 54321)
         check("vmport", False, True)
+        check("kvm_hidden", None, True)
 
         check = self._make_checker(guest.cpu)
         check("match", "exact", "strict")
diff --git a/virtinst/cli.py b/virtinst/cli.py
index 22123d8..a2ecf56 100644
--- a/virtinst/cli.py
+++ b/virtinst/cli.py
@@ -1498,6 +1498,7 @@ class ParserFeatures(VirtCLIParser):
             "hyperv_spinlocks_retries")
 
         self.set_param("features.vmport", "vmport", is_onoff=True)
+        self.set_param("features.kvm_hidden", "kvm_hidden", is_onoff=True)
 
 
 ###################
diff --git a/virtinst/domainfeatures.py b/virtinst/domainfeatures.py
index 16d8ee2..a03c42c 100644
--- a/virtinst/domainfeatures.py
+++ b/virtinst/domainfeatures.py
@@ -48,3 +48,4 @@ class DomainFeatures(XMLBuilder):
 
     vmport = XMLProperty("./vmport/@state", is_onoff=True,
                          default_name="default", default_cb=lambda s: False)
+    kvm_hidden = XMLProperty("./kvm/hidden/@state", is_onoff=True)
-- 
2.4.3




More information about the virt-tools-list mailing list