[virt-tools-list] [PATCH virt-manager]: storage: remove cow as supported format

Cole Robinson crobinso at redhat.com
Tue Sep 29 20:35:13 UTC 2015


On 09/29/2015 01:25 PM, Charles Arnold wrote:
> Support for this format was removed about a year ago from
> qemu with this commit,
> 
> commit 550830f9351291c585c963204ad9127998b1c1ce
> Author: Stefan Hajnoczi <stefanha at redhat.com>
> Date:   Tue Sep 16 15:24:24 2014 +0100
> 
>     block: delete cow block driver
> 
> Signed-off-by: Charles Arnold <carnold at suse.com>
> 
> diff --git a/virtinst/storage.py b/virtinst/storage.py
> index 24973d3..e50b78f 100644
> --- a/virtinst/storage.py
> +++ b/virtinst/storage.py
> @@ -540,7 +540,7 @@ class StorageVolume(_StorageObject):
>      """
>      Base class for building and installing libvirt storage volume xml
>      """
> -    ALL_FORMATS = ["raw", "bochs", "cloop", "cow", "dmg", "iso", "qcow",
> +    ALL_FORMATS = ["raw", "bochs", "cloop", "dmg", "iso", "qcow",
>                     "qcow2", "qed", "vmdk", "vpc", "fat", "vhd", "vdi"]
>  
>      @staticmethod
> @@ -741,7 +741,7 @@ class StorageVolume(_StorageObject):
>  
>      def list_create_formats(self):
>          if self._supports_format():
> -            return ["raw", "cow", "qcow", "qcow2", "qed", "vmdk", "vpc", "vdi"]
> +            return ["raw", "qcow", "qcow2", "qed", "vmdk", "vpc", "vdi"]
>          return None

Thanks, pushed now

- Cole




More information about the virt-tools-list mailing list