[virt-tools-list] [PATCH virt-viewer 0/2] Add file transfer dialog to virt-viewer

[Fabiano Fidêncio]

Jonathon,

On Fri, Apr 8, 2016 at 12:06 AM, Jonathon Jongsma <jjongsma at redhat.com> wrote:
> This is a small patch series that was proposed back in October but then got
> forgotten. There are a few minor changes based on Fabiano's earlier review.

I did a quick review on these patches, without testing them for now
(which I will do later on).
The first patch has a few minor issues, mainly related to checking for
a spice-gtk version we already depend on and checking for a gtk
version ...
The second patch is good to go.

Feel free to resend the series again (or let me know if you want me to
do the clean up). I'd like to do the tests on this series on a Windows
client before actually acking the patches.

>
> Jonathon Jongsma (2):
>   Add file transfer dialog
>   Add some timeouts to file transfer dialog
>
>  src/Makefile.am                        |   2 +
>  src/virt-viewer-file-transfer-dialog.c | 298 +++++++++++++++++++++++++++++++++
>  src/virt-viewer-file-transfer-dialog.h |  65 +++++++
>  src/virt-viewer-session-spice.c        |  35 ++++
>  4 files changed, 400 insertions(+)
>  create mode 100644 src/virt-viewer-file-transfer-dialog.c
>  create mode 100644 src/virt-viewer-file-transfer-dialog.h
>
> --
> 2.4.11
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Best Regards,
--
Fabiano Fidêncio