[virt-tools-list] [PATCH] virtinst: Use virtio bus type for disks on pSeries machines

[Cole Robinson]

On 04/09/2016 03:46 AM, Shivaprasad G Bhat wrote:
> pSeries doesn't support ide and so the default bus type was changed to use the
> scsi before. It is now verified that virtio works better on pSeries with better
> performance outcomes. So, change the default to virtio for disks.
> 
> Signed-off-by: Shivaprasad G Bhat <sbhat at linux.vnet.ibm.com>
> ---
>  virtinst/guest.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtinst/guest.py b/virtinst/guest.py
> index da07410..ab6dcba 100644
> --- a/virtinst/guest.py
> +++ b/virtinst/guest.py
> @@ -1036,7 +1036,7 @@ class Guest(XMLBuilder):
>                      self._os_object.supports_virtiodisk()))):
>                  d.bus = "virtio"
>              elif self.os.is_pseries():
> -                d.bus = "scsi"
> +                d.bus = "virtio"
>              elif self.os.is_arm():
>                  d.bus = "sd"
>              elif self.os.is_q35():
> 

This will break the test suite, you'll need to run 'python setup.py tests
--regenerate-output' to update things

Is this fine to do unconditionally? Or is working virtio support dependent on
new enough qemu or libvirt or guest OS?

- Cole