[virt-tools-list] [Spice-devel] [PATCH] Disable IME to allow receiving all keys

[Fabiano Fidêncio]

On Tue, Apr 19, 2016 at 4:11 PM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
> On Tue, Apr 19, 2016 at 4:00 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
>>>
>>> On Tue, Apr 19, 2016 at 3:28 PM, Pavel Grunt <pgrunt at redhat.com> wrote:
>>> > Ack, I am going to push it.
>>>
>>> Do we really need this patch upstream?
>>> It's a half-solution, at most, that doesn't work on newer Windows.
>>>
>>
>> Are you referring to Window 11? It works on Windows 10.
>
> Hmm. I was basing my comment on
> https://bugzilla.redhat.com/show_bug.cgi?id=1297640#c12 but I didn't
> realize your comment
> https://bugzilla.redhat.com/show_bug.cgi?id=1297640#c13
>
> So, yeah, you have my ACK as well, but a better/more descriptive
> commit message is needed.
>

Patch got applied already, so, nevermind.

>>
>> Frediano
>>
>>> Also, a better commit message would be more than appreciated in case
>>> we really decide to have it upstream.
>>>
>>> >
>>> > Thanks,
>>> > Pavel
>>> >
>>> > On Mon, 2016-04-18 at 14:55 +0100, Frediano Ziglio wrote:
>>> >> From: Christophe Fergeau <cfergeau at redhat.com>
>>> >>
>>> >> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1297640
>>> >>
>>> >> Acked-by: Frediano Ziglio <fziglio at redhat.com>
>>> >> ---
>>> >>  src/virt-viewer-util.c | 7 +++++++
>>> >>  1 file changed, 7 insertions(+)
>>> >>
>>> >> diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c
>>> >> index 279f9a5..8cf52ec 100644
>>> >> --- a/src/virt-viewer-util.c
>>> >> +++ b/src/virt-viewer-util.c
>>> >> @@ -30,6 +30,7 @@
>>> >>  #ifdef G_OS_WIN32
>>> >>  #include <windows.h>
>>> >>  #include <io.h>
>>> >> +#include <imm.h>
>>> >>  #endif
>>> >>
>>> >>  #include <sys/types.h>
>>> >> @@ -272,6 +273,12 @@ void virt_viewer_util_init(const char *appname)
>>> >>          dup2(fileno(stdout), STDOUT_FILENO);
>>> >>          dup2(fileno(stderr), STDERR_FILENO);
>>> >>      }
>>> >> +
>>> >> +    /* Disable input method handling so that the Zenkaku_Hankaku can
>>> >> be passed
>>> >> +     * to VMs rather than being captured by Windows.
>>> >> +     * https://bugzilla.redhat.com/show_bug.cgi?id=1297640
>>> >> +     */
>>> >> +    ImmDisableIME(-1);
>>> >>  #endif
>>> >>
>>> >>      setlocale(LC_ALL, "");
>>> > _______________________________________________
>>> > Spice-devel mailing list
>>> > Spice-devel at lists.freedesktop.org
>>> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
>>>
>>>
>>>
>>> --
>>> Fabiano Fidêncio
>>>
>
>
>
> --
> Fabiano Fidêncio



-- 
Fabiano Fidêncio