[virt-tools-list] [Spice-devel] [PATCH] Disable IME to allow receiving all keys

[Takao Fujiwara]

On 04/20/16 23:45, Christophe Fergeau-san wrote:
> On Wed, Apr 20, 2016 at 05:37:52PM +0900, Takao Fujiwara wrote:
>> My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key
>> events even if the title bar is focused when IME is enabled.
>> I attached the screenshot of the problem when ImmDisableIME(-1) is not applied.
>> https://bugzilla.redhat.com/show_bug.cgi?id=1311858#c42
>>
>> But spice-gtk can receives all the key events and if ImmDisableIME(-1) is applied, users cannot switch IMEs during running Virt-Viewer.
>> I tested native client with Internet Explorer 10 in Windows 7 and I
>> couldn't see any other differences when ImmDisableIME(-1) is applied.
>
> This patch was needed for
> https://bugzilla.redhat.com/show_bug.cgi?id=1297640
> Setup was Windows client connecting to a Windows VM.
> Without this patch, when remote-viewer is focused and the user is
> interacting with the VM, it was not possible to press the
> Zenkaku_Hankaku in order to switch input method within the VM.
>
> Are you saying this is not needed, and that the situation I describe is working
> even without calling ImmDisableIME?

I guess the patch does not fix 1297640.
I mean whether ImmDisableIME(-1) is called or not, Zenkaku_Hankaku is sent to spice-gtk with my test.
I think the root cause is that MapVirtualKey() cannot get the scancode of the released Zenkaku_Hankaku and the remote desktop cannot receive 
Zenkaku_Hankaku.
I observed when the title bar of remote-viewer is focused, Zenkaku_Hankaku event is not sent without this patch.
But I guess the original submitter mistook the issue and the customer's issue would be that Zenkaku_Hankaku is not sent when the window of 
remote-viewer is focused but not the title bar.
And I asked the customers if all the problems are fixed with the patched spice-gtk and without ImmDisableIME(-1).

Thanks,
Fujiwara

>
> Christophe
>