[virt-tools-list] [virt-viewer 1/2] mingw, spec: Add mingw32-nsis as dep

[Fabiano Fidêncio]

On Mon, Apr 25, 2016 at 2:27 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Mon, Apr 25, 2016 at 02:06:51PM +0200, Fabiano Fidêncio wrote:
>> mingw32-nsis provdes "makensis" binary, which is needed for building the
>> ,exe file.
>>
>> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
>> ---
>>  mingw-virt-viewer.spec.in | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/mingw-virt-viewer.spec.in b/mingw-virt-viewer.spec.in
>> index ddea296..247039f 100644
>> --- a/mingw-virt-viewer.spec.in
>> +++ b/mingw-virt-viewer.spec.in
>> @@ -44,6 +44,7 @@ BuildRequires:  mingw32-libvirt-glib >= @LIBVIRT_GLIB_REQUIRED@
>>  BuildRequires:  mingw64-libvirt-glib >= @LIBVIRT_GLIB_REQUIRED@
>>  BuildRequires:  mingw32-libxml2 >= @LIBXML2_REQUIRED@
>>  BuildRequires:  mingw64-libxml2 >= @LIBXML2_REQUIRED@
>> +BuildRequires:  mingw32-nsis
>>  BuildRequires:  mingw32-gtk-vnc2 >= @GTK_VNC_REQUIRED@
>>  BuildRequires:  mingw64-gtk-vnc2 >= @GTK_VNC_REQUIRED@
>>  BuildRequires:  mingw32-readline
>
> Aren't we shipping a msi file these days and moving away from the nsis
> based installer?

We do ship the msi, but for some reason that I don't remember exactly,
we still maintain the nsis.
Maybe the reason is: https://bugzilla.redhat.com/show_bug.cgi?id=1037644


>
> Christophe

Best Regards,
--
Fabiano Fidêncio