[virt-tools-list] [PATCH virt-viewer v2 0/2] Add file transfer dialog to virt-viewer

[Jonathon Jongsma]

On Mon, 2016-04-25 at 14:55 +0200, Fabiano Fidêncio wrote:
> Jonathon,
> 
> On Mon, Apr 11, 2016 at 10:45 PM, Jonathon Jongsma <jjongsma at redhat.com>
> wrote:
> > On Fri, 2016-04-08 at 10:26 -0500, Jonathon Jongsma wrote:
> > > Updated since v1:
> > >  - removed spice-gtk version checks
> > >  - remove conditional gtk2 code
> > >  - use g_clear_pointer to free the hash table in dispose
> > >  - changed copyright date to 2016
> > > 
> > > Jonathon Jongsma (2):
> > >   Add file transfer dialog
> > >   Add some timeouts to file transfer dialog
> > > 
> > >  src/Makefile.am                        |   2 +
> > >  src/virt-viewer-file-transfer-dialog.c | 280
> > > +++++++++++++++++++++++++++++++++
> > >  src/virt-viewer-file-transfer-dialog.h |  61 +++++++
> > >  src/virt-viewer-session-spice.c        |  23 ++-
> > >  4 files changed, 365 insertions(+), 1 deletion(-)
> > >  create mode 100644 src/virt-viewer-file-transfer-dialog.c
> > >  create mode 100644 src/virt-viewer-file-transfer-dialog.h
> > > 
> > 
> > 
> > Hmm, I was doing a little more testing after I sent this out, and I noticed
> > a
> > possible bug that I'm having a hard time reproducing. I started transferring
> > 3
> > files, and cancelled all of them. Then I started another transfer, but the
> > dialog didn't show up. It didn't show up on any future transfer attempts
> > until I
> > restarted virt-viewer. I haven't been able to reproduce this since then. If
> > anybody else runs into this, please let me know.
> 
> I did a few tests with your patches and wasn't able to reproduce the
> issue you described.
> The patches, IMO, are good to be pushed, but before doing that I'd
> like to hear from you what is, exactly, your idea with the timeouts.
> The reason I'm asking this is that when transferring really small
> files, I can't see nothing but something popping out and disappearing
> immediately in my screen. So, do you think would be better to have the
> dialog there for a while? Maybe leave it for the user to close
> (please, no)? Do you think just this "blink" is enough? I'm okay with
> this to be honest.

Ah, it's not supposed to behave this way, actually. If you transfer a really
small file, it should not display a window at all. Will post a new patch
momentarily.


> 
> > 
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/virt-tools-list
> 
> Best Regards,