[virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler
Pavel Grunt
pgrunt at redhat.com
Wed Aug 10 10:41:36 UTC 2016
On Tue, 2016-08-09 at 17:44 +0200, Christophe Fergeau wrote:
> On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote:
> >
> > Just connect to the signal
>
> I'm tempted to ask "why?". I think it's recommended (more efficient) to
> just override the vfunc directly when you can (ie when you derive a new
> widget) rather than connecting to a signal.
no strong reason, just a personal preference coming from the fact that
virt-viewer-display is not "adjusting" its allocation, rather it is only using
it for setting the allocation for its child.
Dropping the patch
Thanks,
Pavel
>
> Christophe
More information about the virt-tools-list
mailing list