[virt-tools-list] [PATCH] virt-manager: console: add submenu for Alt-Sysrq key combos

[Cole Robinson]

On 12/06/2016 02:40 PM, Martin Wilck wrote:
> This patch adds a submenu with Alt-SysRq key combinations to the
> "Send Key" menu of the virt-manager console. As this is useful mostly
> for Linux guests, I added the Linux key "translations" to the menu.
> 
> Feedback is welcome.
> 

Thanks for the patch, but I don't like the idea of an explicit sysrq list.
It's linux guest specific, which isn't a stopper on its own, except even
within linux distros it's not universal: at least fedora only enables a subset
of the sysrq sequences by default, I assume that's the case for other distros
as well. In this case the UI would lead people down the wrong path and I can
imagine fielding bug requests about why a virt-manager menu entry didn't do
what it claims to do (like kill-all-tasks)

I'd rather see this solved with two bits:

- A menu option to pass a manual keycombo to the guest. So it would allow the
user to press alt+sysrq+s individually, then click a 'send' button or similar.
Slow, but flexible

- A way for users to add their own permanent keycombos to the UI. This is
discussed a bit in https://bugzilla.redhat.com/show_bug.cgi?id=1014666 . If we
go with the above 'manual' option, we could add a checkbox like 'Remember this
key combo' that would permanently add it to the UI

Thanks,
Cole