[virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

[Fabiano Fidêncio]

On Sat, Dec 24, 2016 at 12:26 AM, Sagar Ghuge <ghugesss at gmail.com> wrote:
> I assume screenshots are ok.
>
> I will send patch on list soon for review.

Please, send a v2 when all change were done.

This empty space in the fullscreen headerbar makes me think we're not
using the right widget there (or we should tune it a little bit).

>
> On Tue, Dec 20, 2016 at 4:01 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>> On Tue, Dec 20, 2016 at 11:43 AM, Xiaodai Wang <xiaodwan at redhat.com> wrote:
>>>
>>> ----- Original Message -----
>>>> From: "Sagar Ghuge" <ghugesss at gmail.com>
>>>> To: "Fabiano Fidêncio" <fabiano at fidencio.org>
>>>> Cc: "virt" <virt-tools-list at redhat.com>
>>>> Sent: Tuesday, December 20, 2016 5:30:47 PM
>>>> Subject: Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)
>>>>
>>>> Hello everyone,
>>>>
>>>> Here is the screenshots of header bar in fullscreen mode :
>>>> http://imgur.com/a/ZgbS2
>>>>
>>>> Comments and Suggestions most welcome. Thank you.
>>>
>>> will this change affect kiosk mode?
>>
>>
>> As far as I remember there's no timedrevealer/headerbar on kiosk mode.
>> So, no, it won't affect kiosk mode at all.
>>
>>>
>>>
>>>>
>>>> On Mon, Dec 19, 2016 at 4:34 AM, Fabiano Fidêncio <fabiano at fidencio.org>
>>>> wrote:
>>>> > On Mon, Dec 19, 2016 at 1:26 PM, Daniel P. Berrange <berrange at redhat.com>
>>>> > wrote:
>>>> >> On Sat, Dec 17, 2016 at 05:50:11PM +0100, Fabiano Fidêncio wrote:
>>>> >>> From: Sagar Ghuge <ghugesss at gmail.com>
>>>> >>>
>>>> >>> In order to give a modern look to {virt,remote}-viewer let's replace the
>>>> >>> old toolbar for a headerbar (it's the widget shown when the app is
>>>> >>> fullscreen).
>>>> >>>
>>>> >>> The items in the headerbar are exactly the same ones present in the old
>>>> >>> toolbar.
>>>> >>
>>>> >> The old toolbar was only as wide as was needed to display the buttons
>>>> >> and was centered.
>>>> >>
>>>> >> The new headerbar covers the entire screen  width with 90% empty space
>>>> >> which is quite ugly and not user friendly as it obscures a good portion
>>>> >> of the guest display too.
>>>> >
>>>> > Right. The decision of doing this is mine based on Boxes design.
>>>> > If you prefer to have it in the middle, it's quite simple thing to do.
>>>> > Later Today or Tomorrow I'll send some screenshots about how it looks.
>>>> >
>>>> >>
>>>> >> Regards,
>>>> >> Daniel
>>>> >> --
>>>> >> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/
>>>> >> |:|
>>>> >> |: http://libvirt.org              -o-             http://virt-manager.org
>>>> >> |:|
>>>> >> |: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/
>>>> >> |:|
>>>> >>
>>>> >> _______________________________________________
>>>> >> virt-tools-list mailing list
>>>> >> virt-tools-list at redhat.com
>>>> >> https://www.redhat.com/mailman/listinfo/virt-tools-list
>>>> >
>>>> >
>>>> > Best Regards,
>>>> > --
>>>> > Fabiano Fidêncio
>>>>
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Sagar
>>>>
>>>> _______________________________________________
>>>> virt-tools-list mailing list
>>>> virt-tools-list at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/virt-tools-list
>>
>>
>>
>> --
>> Fabiano Fidêncio
>
>
>
> --
> Regards,
> Sagar



-- 
Fabiano Fidêncio