[virt-tools-list] [PATCH virt-viewer] display: Set value of desktop width and height property directly

Eduardo Lima (Etrunko) etrunko at redhat.com
Tue Feb 2 11:47:33 UTC 2016


On 01/27/2016 03:33 PM, Pavel Grunt wrote:
> Avoid calling gtk_widget_queue_resize() and emitting
> the "display-desktop-resize" signal.

Just curious about why this change is necessary? I mean, isn't this
signal necessary somewhere else? I see it is handled in VirtViewerWindow.

If so, please provide some more details in the commit message.

> ---
>  src/virt-viewer-display.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c
> index d1b088e..af1fe01 100644
> --- a/src/virt-viewer-display.c
> +++ b/src/virt-viewer-display.c
> @@ -301,14 +301,10 @@ virt_viewer_display_set_property(GObject *object,
>  
>      switch (prop_id) {
>      case PROP_DESKTOP_WIDTH:
> -        virt_viewer_display_set_desktop_size(display,
> -                                             g_value_get_int(value),
> -                                             priv->desktopHeight);
> +        priv->desktopWidth = g_value_get_int(value);
>          break;
>      case PROP_DESKTOP_HEIGHT:
> -        virt_viewer_display_set_desktop_size(display,
> -                                             priv->desktopWidth,
> -                                             g_value_get_int(value));
> +        priv->desktopHeight = g_value_get_int(value);
>          break;
>      case PROP_NTH_DISPLAY:
>          priv->nth_display = g_value_get_int(value);
> 


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list