[virt-tools-list] [PATCH virt-viewer] display: Set value of desktop width and height property directly

[Eduardo Lima (Etrunko)]

On 02/02/2016 10:59 AM, Pavel Grunt wrote:
> Hi,
> 
> On Tue, 2016-02-02 at 09:47 -0200, Eduardo Lima (Etrunko) wrote:
>> On 01/27/2016 03:33 PM, Pavel Grunt wrote:
>>> Avoid calling gtk_widget_queue_resize() and emitting
>>> the "display-desktop-resize" signal.
>>
>> Just curious about why this change is necessary? I mean, isn't this
>> signal necessary somewhere else? I see it is handled in
>> VirtViewerWindow.
>>
> these properties are only used
> by virt_viewer_display_spice_set_desktop() which will emit the signal
> and call the function. I want to prevent multiple calls
> to virt_viewer_display_queue_resize() when changing both properties.
> 
>> If so, please provide some more details in the commit message.
> 
> what about:
> 
>     display: Set value of desktop width and height property directly
> 
>     Avoid calling gtk_widget_queue_resize() and emiting
>     the "display-desktop-resize" signal.
>     The only user of the properties is
> virt_viewer_display_spice_set_desktop()
>     which will call the function and emit the signal after setting both
>     "desktop-width" and "desktop-height" properties.
> 

Yes, much better, thanks. :)

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com