[virt-tools-list] [virt-manager PATCH v2] localization: mark several strings as translatable

[Christophe Fergeau]

Hey,

On Fri, Feb 05, 2016 at 05:45:13PM +0100, Pavel Hrdina wrote:
> diff --git a/virtManager/connect.py b/virtManager/connect.py
> index 7878611..1b218e5 100644
> --- a/virtManager/connect.py
> +++ b/virtManager/connect.py
> @@ -165,9 +165,9 @@ class vmmConnect(vmmGObjectUI):
>                  model.append([rowid, label])
>  
>          _add_hv_row(HV_QEMU, "qemu", "QEMU/KVM")
> -        _add_hv_row(HV_QEMU_SESSION, "qemu", "QEMU/KVM user session")
> +        _add_hv_row(HV_QEMU_SESSION, "qemu", "QEMU/KVM " + _("user session"))



> @@ -176,7 +176,7 @@ class vmmConnect(vmmGObjectUI):
>          model = Gtk.ListStore(str)
>          model.append(["SSH"])
>          model.append(["TCP (SASL, Kerberos)"])
> -        model.append(["SSL/TLS with certificates"])
> +        model.append(["SSL/TLS " + _("with certificates)"])
>          combo.set_model(model)
>          uiutil.init_combo_text_column(combo, 0)

Building strings through concatenation can be problematic in some
languages, the translator may need SSL/TLS (or QEMU/KVM) to come after
the translated string, or they may need to append some termination to it
depending on what comes after it, or they may want to write it in a
different script because that's how things are done in their language,
...
In short, I would mark the whole string as translatable in these 2 cases
(there are other locations where it may apply, I only picked these 2 for
this mail).

Chirstophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20160206/94553e5a/attachment.sig>