[virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

Eduardo Lima (Etrunko) etrunko at redhat.com
Mon Feb 15 14:15:44 UTC 2016


On 02/15/2016 11:57 AM, Fabiano Fidêncio wrote:
> 
> NACK from me.
> There is no reason for keeping an empty virt-glib-compat.c file.
> virt-glib-compat.h also could be removed entirely as g_clear_pointer()
> was introduced in 2.34. So, please, remove both files from the tree.
> 
> Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>
> 

Indeed, I did not check when g_clear_pointer was introduced. I will
remove the files then.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list