[virt-tools-list] [PATCH virt-viewer v2] README: update information

Pavel Grunt pgrunt at redhat.com
Tue Feb 23 17:24:28 UTC 2016


On Tue, 2016-02-23 at 11:13 -0600, Jonathon Jongsma wrote:
> On Tue, 2016-02-23 at 17:51 +0100, Pavel Grunt wrote:
> > Remove info about gtk versions
> > Fix a typo
> > Change link for spice-gtk widget
> > ---
> >  README | 12 ++++--------
> >  1 file changed, 4 insertions(+), 8 deletions(-)
> > 
> > diff --git a/README b/README
> > index 289bc86..20a8818 100644
> > --- a/README
> > +++ b/README
> > @@ -4,17 +4,13 @@
> >  Virt Viewer provides a graphical viewer for the guest OS
> >  display. At this time is supports guest OS using the VNC
> >  or SPICE protocols. Further protocols may be supported in
> > -the future as user demand dicatates. The viewer can connect
> > +the future as user demand dictates. The viewer can connect
> >  directly to both local and remotely hosted guest OS, optionally
> >  using SSL/TLS encryption.
> >  
> > -Virt Viewer can be built with either GTK2 or GTK3, with the
> > -default option currently being GTK2. The choice can be made
> > -with:
> > +Virt Viewer is uses GTK3. The last version using GTK2 is 3.0.
> 
> I must say, it's a little bit unfortunate that the version that
> supports gtk 2
> is numbered 3.0. My brain wanted to read that a couple times before
> it made
> sense to me. For me, this makes it a little easier to parse without
> having to
> think quite so hard:
> 
> "Virt Viewer 3.0 was the last release that supported GTK2"
> 
> Nitpicking. Feel free to use whatever.
> 
Thanks, taking your suggestion.

Pavel
> 
> 
> >  
> > -   ./configure --with-gtk=3.0  (or =2.0)
> > -
> > -Virt Viewer uses the GTK-VNC (>= 0.4.3) widget to provide a
> > +Virt Viewer uses the GTK-VNC (>= 0.4.0) widget to provide a
> >  display of the VNC protocol, which is available from
> >  
> >    http://gtk-vnc.sourceforge.net/
> > @@ -22,7 +18,7 @@ display of the VNC protocol, which is available
> > from
> >  Virt Viewer uses the SPICE-GTK (>= 0.30) widget to provide a
> >  display of the SPICE protocol, which is available from:
> >  
> > -  http://spice-space.org/page/Spice-Gtk
> > +  http://www.spice-space.org/download.html
> >  
> >  Use of either SPICE-GTK or GTK-VNC can be disabled at time
> >  of configure, with --without-gtk-vnc or --without-spice-gtk




More information about the virt-tools-list mailing list