[virt-tools-list] [virt-viewer v2 0/5] A bunch of cleanups

[Fabiano Fidêncio]

On Wed, Feb 24, 2016 at 8:04 AM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> As GTK2 is gone and we have been depending on GLib 2.38 and
> GTK 3.10, let's ensure we don't add anything newer than that
> (or that at least we get a warning if we do).
> Also, clean up all the old code not used anymore and avoid
> a bunch of deprecated warnings.
>
> There is one warning that still remains:
>
> virt-viewer-session-vnc.c: In function
> 'virt_viewer_session_vnc_auth_credential':
> virt-viewer-session-vnc.c:272:9: warning: 'g_value_array_get_nth' is
> deprecated: Use 'GArray' instead [-Wdeprecated-declarations]
>     GValue *cred = g_value_array_get_nth(credList, i);
>     ^
> In file included from /usr/include/glib-2.0/glib-object.h:35:0,
>    from /usr/include/glib-2.0/gio/gioenums.h:28,
>    from /usr/include/glib-2.0/gio/giotypes.h:28,
>    from /usr/include/glib-2.0/gio/gio.h:26,
>    from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28,
>    from /usr/include/gtk-3.0/gdk/gdk.h:32,
>    from /usr/include/gtk-3.0/gtk/gtk.h:30,
>    from virt-viewer-session.h:27,
>    from virt-viewer-auth.h:32,
>    from virt-viewer-session-vnc.c:27:
> /usr/include/glib-2.0/gobject/gvaluearray.h:63:10: note: declared here
> GValue*  g_value_array_get_nth      (GValueArray *value_array,
>          ^
> virt-viewer-session-vnc.c:319:9: warning: 'g_value_array_get_nth' is
> deprecated: Use 'GArray' instead [-Wdeprecated-declarations]
>     GValue *cred = g_value_array_get_nth(credList, i);
>     ^
> In file included from /usr/include/glib-2.0/glib-object.h:35:0,
>     from /usr/include/glib-2.0/gio/gioenums.h:28,
>     from /usr/include/glib-2.0/gio/giotypes.h:28,
>     from /usr/include/glib-2.0/gio/gio.h:26,
>     from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28,
>     from /usr/include/gtk-3.0/gdk/gdk.h:32,
>     from /usr/include/gtk-3.0/gtk/gtk.h:30,
>     from virt-viewer-session.h:27,
>     from virt-viewer-auth.h:32,
>     from virt-viewer-session-vnc.c:27:
> /usr/include/glib-2.0/gobject/gvaluearray.h:63:10: note: declared here
> GValue*  g_value_array_get_nth      (GValueArray *value_array,
>          ^
>
> It happens due to a gtk-vnc callback which uses GValueArray. Changing
> it would be an API breakage. Introducing new callbacks is the way to
> go, but I won't do it right now, as we would still be depending on a
> unreleased version of gtk-vnc.
>
> Fabiano Fidêncio (5):
>   Use GLIB_VERSION_MAX_ALLOWED -- not reviewed yet
>   Use GDK_VERSION_MAX_ALLOWED -- not reviewed yet
>   cleanup: Drop old compatibilty code -- already acked by Jonathon
>   cleanup: Don't use stock icons -- reviewed by Jonathon
>     -- changes since v1:
>        - Since we're using labels instead of stock items, change the
>          GtkImageMenuItem to GtkMenuItem.
>        - Add a note in the commit message that we are adding new strings
>          that will need to be translated.
>   cleanup: Don't use gtk_widget_modify_{fg,bg}() -- reviewed by Jonathon and Pavel
>     -- changes since v1:
>        - Replace gtk_widget_modify_bg() for gtk_widget_override_background_color()
>          instead of gtk_widget_override_color()
>        - Add a FIXME when using gtk_widget_override{,_background}_color() functions
>          mentioning that they are deprecated since 3.16.
>
>  acinclude.m4                      |    2 +-
>  configure.ac                      |   19 +-
>  po/POTFILES.in                    |    1 -
>  src/Makefile.am                   |    2 -
>  src/gbinding.c                    | 1221 -------------------------------------
>  src/gbinding.h                    |  129 ----
>  src/virt-viewer-app.c             |    2 -
>  src/virt-viewer-auth.xml          |    8 +-
>  src/virt-viewer-guest-details.xml |    4 +-
>  src/virt-viewer-notebook.c        |   11 +-
>  src/virt-viewer-session-spice.c   |    6 +-
>  src/virt-viewer-util.c            |    4 -
>  src/virt-viewer-vm-connection.xml |    8 +-
>  src/virt-viewer-window.c          |   21 +-
>  src/virt-viewer.xml               |   25 +-
>  15 files changed, 61 insertions(+), 1402 deletions(-)
>  delete mode 100644 src/gbinding.c
>  delete mode 100644 src/gbinding.h
>
> --
> 2.5.0
>

With all the comments addressed, this series got pushed upstream!
Thanks.