[virt-tools-list] [PATCH] display: Set useful values for MIN_DISPLAY_{WIDTH, HEIGHT}

[Fabiano Fidêncio]

On Tue, Jan 12, 2016 at 9:57 AM, Pavel Grunt <pgrunt at redhat.com> wrote:
> Hi,
>
> On Mon, 2016-01-11 at 23:39 +0100, Fabiano Fidêncio wrote:
>> Nowadays the value for MIN_DISPLAY_{WIDTH,HEIGHT} is 50. This
>> arbitrary
>> value doesn't bring any benefit, doesn't provide a useful size for a
>> desktop to be usable and can actually trigger some undefined behavior
>> when reaching resolutions that are lower than the ones provided by
>> the
>> video drivers (as in rhbz#1296878).
>> In order to avoid these issues and provide a minimum resolution that
>> can
>> still be useful for our users, let's use the same values for minimum
>> width and height used by the linux QXL drivers (320x200).
>
> Considering that you have to do weird stuff to hit the issue, the
> problem will still exist if you use a zoom level > 100.

Your comment made me think for a while and I don't think we should
allow to resize a window with a specified zoom level.
I've sent a patch with my suggestion:
https://www.redhat.com/archives/virt-tools-list/2016-January/msg00026.html

>
> Pavel
>
>>
>> Related: rhbz#1296878
>> ---
>>  src/virt-viewer-display.c | 4 ++--
>>  src/virt-viewer-display.h | 4 ++--
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c
>> index 036b713..cda1c8b 100644
>> --- a/src/virt-viewer-display.c
>> +++ b/src/virt-viewer-display.c
>> @@ -116,7 +116,7 @@
>> virt_viewer_display_class_init(VirtViewerDisplayClass *class)
>>                                                       "Desktop
>> width",
>>                                                       MIN_DISPLAY_WID
>> TH,
>>                                                       G_MAXINT32,
>> -                                                     100,
>> +                                                     MIN_DISPLAY_WID
>> TH,
>>                                                       G_PARAM_READWRI
>> TE));
>>
>>      g_object_class_install_property(object_class,
>> @@ -126,7 +126,7 @@
>> virt_viewer_display_class_init(VirtViewerDisplayClass *class)
>>                                                       "Desktop
>> height",
>>                                                       MIN_DISPLAY_HEI
>> GHT,
>>                                                       G_MAXINT32,
>> -                                                     100,
>> +                                                     MIN_DISPLAY_HEI
>> GHT,
>>                                                       G_PARAM_READWRI
>> TE));
>>
>>      g_object_class_install_property(object_class,
>> diff --git a/src/virt-viewer-display.h b/src/virt-viewer-display.h
>> index a899bb4..a279697 100644
>> --- a/src/virt-viewer-display.h
>> +++ b/src/virt-viewer-display.h
>> @@ -29,8 +29,8 @@
>>
>>  G_BEGIN_DECLS
>>
>> -#define MIN_DISPLAY_WIDTH 50
>> -#define MIN_DISPLAY_HEIGHT 50
>> +#define MIN_DISPLAY_WIDTH 320
>> +#define MIN_DISPLAY_HEIGHT 200
>>
>>  #define VIRT_VIEWER_TYPE_DISPLAY virt_viewer_display_get_type()
>>
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list



-- 
Fabiano Fidêncio