[virt-tools-list] [PATCH] Drop GSlice usage

Fabiano Fidêncio fabiano at fidencio.org
Mon Jan 18 09:45:17 UTC 2016


Pavel,

On Mon, Jan 18, 2016 at 10:14 AM, Pavel Grunt <pgrunt at redhat.com> wrote:
> Hi,
>
> Ack if you add some explanation to the commit log.

"It's being slowly deprecated im glib
https://bugzilla.gnome.org/show_bug.cgi?id=754687"

That would be the commit log, but I forgot to add before sending.
Is it okay for you?

>
> Thanks,
> Pavel
>
> On Mon, 2016-01-18 at 10:04 +0100, Fabiano Fidêncio wrote:
>> ---
>>  src/gbinding.c         | 4 ++--
>>  src/virt-viewer-util.c | 4 ++--
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/gbinding.c b/src/gbinding.c
>> index 4b2f5b1..a090015 100644
>> --- a/src/gbinding.c
>> +++ b/src/gbinding.c
>> @@ -1149,7 +1149,7 @@ bind_with_closures_free_func (gpointer data)
>>    if (t_data->transform_from_closure != NULL)
>>      g_closure_unref (t_data->transform_from_closure);
>>
>> -  g_slice_free (TransformData, t_data);
>> +  g_free (t_data);
>>  }
>>
>>  /**
>> @@ -1191,7 +1191,7 @@ g_object_bind_property_with_closures
>> (gpointer       source,
>>  {
>>    TransformData *data;
>>
>> -  data = g_slice_new0 (TransformData);
>> +  data = g_new0 (TransformData, 1);
>>
>>    if (transform_to != NULL)
>>      {
>> diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c
>> index f2ccd13..c6bef1b 100644
>> --- a/src/virt-viewer-util.c
>> +++ b/src/virt-viewer-util.c
>> @@ -173,7 +173,7 @@ static WeakHandlerCtx *
>>  whc_new(GObject *instance,
>>          GObject *observer)
>>  {
>> -    WeakHandlerCtx *ctx = g_slice_new0(WeakHandlerCtx);
>> +    WeakHandlerCtx *ctx = g_new0(WeakHandlerCtx, 1);
>>
>>      ctx->instance = instance;
>>      ctx->observer = observer;
>> @@ -184,7 +184,7 @@ whc_new(GObject *instance,
>>  static void
>>  whc_free(WeakHandlerCtx *ctx)
>>  {
>> -    g_slice_free(WeakHandlerCtx, ctx);
>> +    g_free(ctx);
>>  }
>>
>>  static void observer_destroyed_cb(gpointer, GObject *);
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list



-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list