[virt-tools-list] [PATCH] virtinst: Support paths to SUSE OVMF firmwares

[Jim Fehlig]

Cole Robinson wrote:
> On 01/27/2016 09:51 PM, Jim Fehlig wrote:
>> Extend the domcapabilities regex to include SUSE's OVMF
>> file naming convention.
>>
>> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>> ---
>>  virtinst/domcapabilities.py | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py
>> index 86bdfe8..f074b4e 100644
>> --- a/virtinst/domcapabilities.py
>> +++ b/virtinst/domcapabilities.py
>> @@ -101,6 +101,7 @@ class DomainCapabilities(XMLBuilder):
>>          "x86_64": [
>>              ".*OVMF_CODE\.fd",  # RHEL
>>              ".*ovmf-x64/OVMF.*\.fd",  # gerd's firmware repo
>> +            ".*ovmf-x86_64-.*", # SUSE
>>          ],
>>          "aarch64": [
>>              ".*AAVMF_CODE\.fd",  # RHEL
>>
> 
> ACK and pushed, thanks! Patches like this are definitely appreciated for
> upstream, since ideally virt-manager.git works out of the box on any distro.
> 
> "gerd's firmware repo" probably sounds weird, but it's the recommended way to
> consume ovmf on fedora, since we can't package it yet due to Fedora's license
> policies. Details here if you're curious:
> 
> https://fedoraproject.org/wiki/Using_UEFI_with_QEMU

Ah, interesting. Thanks.

> Unfortunately having to hardcode this stuff in the tools is suboptimal,
> hopefully long term we figure out a better solution at the libvirt level. I
> blogged a bit about it a few weeks ago:
> 
> http://blog.wikichoon.com/2016/01/uefi-support-in-virt-install-and-virt.html

Your blog post helped me quickly locate the code in virtinst needing adjustment :-).

Regards,
Jim