[virt-tools-list] [virt-manager PATCH 2/3] tests.xmlparse: fix network test

Pavel Hrdina phrdina at redhat.com
Fri Jul 8 16:11:17 UTC 2016


Device <interface type='ethernet'/> doesn't support <source dev=''/> attribute.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 tests/xmlparse-xml/change-nics-in.xml  | 1 -
 tests/xmlparse-xml/change-nics-out.xml | 1 -
 tests/xmlparse.py                      | 1 -
 3 files changed, 3 deletions(-)

diff --git a/tests/xmlparse-xml/change-nics-in.xml b/tests/xmlparse-xml/change-nics-in.xml
index 944c290..7e16847 100644
--- a/tests/xmlparse-xml/change-nics-in.xml
+++ b/tests/xmlparse-xml/change-nics-in.xml
@@ -32,7 +32,6 @@
     </interface>
     <interface type="ethernet">
       <mac address="00:11:22:33:44:55"/>
-      <source dev="eth0"/>
       <script path="/etc/qemu-ifup"/>
       <target dev="nic02"/>
     </interface>
diff --git a/tests/xmlparse-xml/change-nics-out.xml b/tests/xmlparse-xml/change-nics-out.xml
index 0af04a0..0dd8e5a 100644
--- a/tests/xmlparse-xml/change-nics-out.xml
+++ b/tests/xmlparse-xml/change-nics-out.xml
@@ -35,7 +35,6 @@
     </interface>
     <interface type="ethernet">
       <mac address="00:11:22:33:44:55"/>
-      <source dev="eth1"/>
       <script path="/etc/qemu-ifup"/>
     </interface>
     <interface type="direct">
diff --git a/tests/xmlparse.py b/tests/xmlparse.py
index f380d06..9697fbf 100644
--- a/tests/xmlparse.py
+++ b/tests/xmlparse.py
@@ -551,7 +551,6 @@ class XMLParseTest(unittest.TestCase):
 
         check = self._make_checker(dev4)
         check("type", "ethernet")
-        check("source", "eth0", "eth1")
         check("target_dev", "nic02", "nic03")
         check("target_dev", "nic03", None)
 
-- 
2.9.0




More information about the virt-tools-list mailing list