[virt-tools-list] [PATCH virt-viewer 00/11] Replace oVirt foreign menu with dedicated dialog

Eduardo Lima (Etrunko) etrunko at redhat.com
Mon Jul 18 02:13:00 UTC 2016


After analyzing the causes of the bug reported in rhbz #1310624, we came
to the conclusion that the whole idea of having a menu to display a list
remote files seemed wrong. A temporary solution has been provided until
the code was reworked, and this is the result.

Most of the changes is in ovirt-foreign menu, which does not handle any
UI widgets anymore, and some accessors were added so that other objects
can interface with it.

The dialog itself is pretty simple, and displays the list of files using
a GtkTreeView widget. It was designed using glade, which made the
development easier than programming the whole UI manually.

Eduardo Lima (Etrunko) (11):
  ovirt-foreign-menu: Rework states logic
  ovirt-foreign-menu: Use g_clear_pointer/g_clear_object
  ovirt-foreign-menu: Remove timer used to refresh iso list
  ovirt-foreign-menu: Add accessors for current iso and iso list
  ovirt-foreign-menu: Remove GtkMenu related functions
  ovirt-foreign-menu: Notify of new files even if list did not change
  UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu
  Introduce ISO List dialog
  Run iso-dialog when 'Change CD' menu is activated
  remote-viewer: Make ovirt-foreign-menu a property
  iso-dialog: Implement functionality provided by oVirt foreign menu

 src/Makefile.am                            |   3 +
 src/ovirt-foreign-menu.c                   | 290 +++++++++--------------------
 src/ovirt-foreign-menu.h                   |   5 +-
 src/remote-viewer-iso-list-dialog.c        | 274 +++++++++++++++++++++++++++
 src/remote-viewer-iso-list-dialog.h        |  59 ++++++
 src/remote-viewer.c                        |  88 ++++-----
 src/resources/ui/remote-viewer-iso-list.ui | 176 +++++++++++++++++
 src/resources/ui/virt-viewer.ui            |  58 +++---
 src/resources/virt-viewer.gresource.xml    |   1 +
 src/virt-viewer-window.c                   |  43 +++++
 10 files changed, 715 insertions(+), 282 deletions(-)
 create mode 100644 src/remote-viewer-iso-list-dialog.c
 create mode 100644 src/remote-viewer-iso-list-dialog.h
 create mode 100644 src/resources/ui/remote-viewer-iso-list.ui

-- 
2.7.4




More information about the virt-tools-list mailing list