[virt-tools-list] [virt-manager PATCH] maint: fix pylint warnings wrong-import-order

Pavel Hrdina phrdina at redhat.com
Tue Jun 7 15:39:12 UTC 2016


standard import "import logging" comes before "from gi.repository import GLib"

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---

Pushed

 virtManager/connectauth.py     |  6 +++---
 virtManager/connection.py      |  5 +++--
 virtManager/console.py         |  4 ++--
 virtManager/createinterface.py |  4 ++--
 virtManager/createpool.py      |  4 ++--
 virtManager/delete.py          |  8 ++++----
 virtManager/domain.py          |  4 ++--
 virtManager/engine.py          | 10 +++++-----
 virtManager/error.py           |  4 ++--
 virtManager/libvirtobject.py   |  4 ++--
 virtManager/packageutils.py    |  4 ++--
 virtManager/viewers.py         |  6 +++---
 12 files changed, 32 insertions(+), 31 deletions(-)

diff --git a/virtManager/connectauth.py b/virtManager/connectauth.py
index 635fce7..014a986 100644
--- a/virtManager/connectauth.py
+++ b/virtManager/connectauth.py
@@ -18,13 +18,13 @@
 # MA 02110-1301 USA.
 #
 
-from gi.repository import GLib
-from gi.repository import Gio
-
 import logging
 import os
 import time
 
+from gi.repository import GLib
+from gi.repository import Gio
+
 import libvirt
 
 
diff --git a/virtManager/connection.py b/virtManager/connection.py
index 26a4584..6cb9cc0 100644
--- a/virtManager/connection.py
+++ b/virtManager/connection.py
@@ -18,8 +18,6 @@
 # MA 02110-1301 USA.
 #
 
-from gi.repository import GObject
-
 import logging
 import os
 import threading
@@ -27,6 +25,9 @@ import time
 import traceback
 
 import libvirt
+
+from gi.repository import GObject
+
 import virtinst
 from virtinst import pollhelpers
 from virtinst import support
diff --git a/virtManager/console.py b/virtManager/console.py
index aa208d0..aaee859 100644
--- a/virtManager/console.py
+++ b/virtManager/console.py
@@ -19,11 +19,11 @@
 # MA 02110-1301 USA.
 #
 
+import logging
+
 from gi.repository import Gtk
 from gi.repository import Gdk
 
-import logging
-
 from .baseclass import vmmGObject, vmmGObjectUI
 from .details import DETAILS_PAGE_CONSOLE
 from .serialcon import vmmSerialConsole
diff --git a/virtManager/createinterface.py b/virtManager/createinterface.py
index fd21a27..82e69cb 100644
--- a/virtManager/createinterface.py
+++ b/virtManager/createinterface.py
@@ -18,11 +18,11 @@
 # MA 02110-1301 USA.
 #
 
+import logging
+
 from gi.repository import Gtk
 from gi.repository import Gdk
 
-import logging
-
 from virtinst import Interface, InterfaceProtocol
 
 from . import uiutil
diff --git a/virtManager/createpool.py b/virtManager/createpool.py
index 1eaa805..b17c083 100644
--- a/virtManager/createpool.py
+++ b/virtManager/createpool.py
@@ -18,12 +18,12 @@
 # MA 02110-1301 USA.
 #
 
+import logging
+
 from gi.repository import Gdk
 from gi.repository import GObject
 from gi.repository import Gtk
 
-import logging
-
 from .baseclass import vmmGObjectUI
 from .asyncjob import vmmAsyncJob
 from . import uiutil
diff --git a/virtManager/delete.py b/virtManager/delete.py
index 4c01db9..e3d4c00 100644
--- a/virtManager/delete.py
+++ b/virtManager/delete.py
@@ -18,15 +18,15 @@
 # MA 02110-1301 USA.
 #
 
-from gi.repository import Gtk
-from gi.repository import Gdk
-from gi.repository import Pango
-
 import os
 import stat
 import traceback
 import logging
 
+from gi.repository import Gtk
+from gi.repository import Gdk
+from gi.repository import Pango
+
 import virtinst
 from virtinst import util
 
diff --git a/virtManager/domain.py b/virtManager/domain.py
index f6cb40c..a978cb9 100644
--- a/virtManager/domain.py
+++ b/virtManager/domain.py
@@ -18,8 +18,6 @@
 # MA 02110-1301 USA.
 #
 
-from gi.repository import GObject
-
 import logging
 import os
 import time
@@ -27,6 +25,8 @@ import threading
 
 import libvirt
 
+from gi.repository import GObject
+
 from virtinst import DomainCapabilities
 from virtinst import DomainSnapshot
 from virtinst import Guest
diff --git a/virtManager/engine.py b/virtManager/engine.py
index 001ef91..7e06460 100644
--- a/virtManager/engine.py
+++ b/virtManager/engine.py
@@ -18,17 +18,17 @@
 # MA 02110-1301 USA.
 #
 
-from gi.repository import Gio
-from gi.repository import GLib
-from gi.repository import GObject
-from gi.repository import Gtk
-
 import logging
 import re
 import Queue
 import threading
 import traceback
 
+from gi.repository import Gio
+from gi.repository import GLib
+from gi.repository import GObject
+from gi.repository import Gtk
+
 from . import packageutils
 from .about import vmmAbout
 from .baseclass import vmmGObject
diff --git a/virtManager/error.py b/virtManager/error.py
index af235be..6f16169 100644
--- a/virtManager/error.py
+++ b/virtManager/error.py
@@ -17,11 +17,11 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
 # MA 02110-1301 USA.
 
-from gi.repository import Gtk
-
 import logging
 import traceback
 
+from gi.repository import Gtk
+
 from .baseclass import vmmGObject
 
 
diff --git a/virtManager/libvirtobject.py b/virtManager/libvirtobject.py
index 933a61f..3304401 100644
--- a/virtManager/libvirtobject.py
+++ b/virtManager/libvirtobject.py
@@ -18,10 +18,10 @@
 # MA 02110-1301 USA.
 #
 
-from gi.repository import GObject
-
 import logging
 
+from gi.repository import GObject
+
 from .baseclass import vmmGObject
 
 
diff --git a/virtManager/packageutils.py b/virtManager/packageutils.py
index cf20d6d..31246e6 100644
--- a/virtManager/packageutils.py
+++ b/virtManager/packageutils.py
@@ -18,11 +18,11 @@
 # MA 02110-1301 USA.
 #
 
-from gi.repository import Gio
-
 import logging
 import time
 
+from gi.repository import Gio
+
 
 #############################
 # PackageKit lookup helpers #
diff --git a/virtManager/viewers.py b/virtManager/viewers.py
index 4161a5c..403c316 100644
--- a/virtManager/viewers.py
+++ b/virtManager/viewers.py
@@ -19,6 +19,9 @@
 # MA 02110-1301 USA.
 #
 
+import logging
+import socket
+
 from gi.repository import GObject
 from gi.repository import Gdk
 
@@ -33,9 +36,6 @@ try:
 except (ValueError, ImportError):
     have_spice_gtk = False
 
-import logging
-import socket
-
 from .baseclass import vmmGObject
 from .sshtunnels import SSHTunnels
 
-- 
2.8.3




More information about the virt-tools-list mailing list