[virt-tools-list] [virt-manager PATCH 1/2] console: fix checkbox to save password if it was loaded from keyring

[Cole Robinson]

On 06/07/2016 11:20 AM, Pavel Hrdina wrote:
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1302175
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  virtManager/console.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/virtManager/console.py b/virtManager/console.py
> index aa208d0..66e89d8 100644
> --- a/virtManager/console.py
> +++ b/virtManager/console.py
> @@ -623,11 +623,11 @@ class vmmConsolePages(vmmGObjectUI):
>          self.widget("console-auth-username").set_text(username)
>          self.widget("console-auth-password").set_text(pw)
>  
> -        self.widget("console-auth-remember").set_sensitive(
> -                bool(self.config.has_keyring()))

Is console-auth-remember insensitive by default? Otherwise moving this bit
into the lower block may not be correct, in the case when there isn't any
'Secrets' API dbus provider available the checkbox may still be set as sensitive

ACK otherwise

- Cole

>          if self.config.has_keyring():
> -            self.widget("console-auth-remember").set_active(
> -                bool(pw and username))
> +            self.widget("console-auth-remember").set_sensitive(True)
> +
> +            if (withPassword and pw) or (withUsername and username):
> +                self.widget("console-auth-remember").set_active(True)
>  
>          self.widget("console-pages").set_current_page(
>              _CONSOLE_PAGE_AUTHENTICATE)
>