[virt-tools-list] [virt-manager PATCH] details: Show users a clue about where to map UEFI/OVMF path in libvirtd

[Cole Robinson]

On 06/11/2016 10:44 AM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  virtManager/details.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/virtManager/details.py b/virtManager/details.py
> index 0c369a4..0ac0549 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -826,7 +826,10 @@ class vmmDetails(vmmGObjectUI):
>          elif not uefipaths:
>              warn_icon.set_tooltip_text(
>                  _("Libvirt did not detect any UEFI/OVMF firmware image "
> -                  "installed on the host."))
> +                  "installed on the host." + "\n\n" + "Please check if "
> +                  "you have UEFI/OVMF firmware installed and if nvram "
> +                  "option is configured in libvirtd's qemu.conf then "
> +                  "restart libvirtd."))
>  

Thanks for the patch, but I don't really like this. For one, checking
qemu.conf isn't really accurate, since the default ovmf list can be specified
via libvirt ./configure options, and in that case qemu.conf isn't accurate.
Secondly, ovmf work is ongoing for the xen driver, so references to qemu.conf
aren't generally applicable.

I don't really have a better suggestion though... maybe put up a wiki page or
blog post with that error and explain what could be going wrong, so people can
google for it?

- Cole

>          model.append([domcaps.label_for_firmware_path(None), None, True])
>          if not uefipaths:
>