[virt-tools-list] [PATCH python] storagelist: code cleanup

Cole Robinson crobinso at redhat.com
Tue Jun 14 23:19:36 UTC 2016


On 06/14/2016 05:56 PM, Jovanka Gulicoska wrote:
> Remove cb() function calling pool.refresh, instead use pool.refresh
> in vmmAsyncJob
> ---
>  virtManager/storagelist.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/virtManager/storagelist.py b/virtManager/storagelist.py
> index 8a34e7f..c16cf5c 100644
> --- a/virtManager/storagelist.py
> +++ b/virtManager/storagelist.py
> @@ -654,11 +654,8 @@ class vmmStorageList(vmmGObjectUI):
>          if pool is None:
>              return
>  
> -        def cb():
> -            pool.refresh()
> -
>          logging.debug("Refresh pool '%s'", pool.get_name())
> -        vmmAsyncJob.simple_async_noshow(cb, [], self,
> +        vmmAsyncJob.simple_async_noshow(pool.refresh, [], self,
>                              _("Error refreshing pool '%s'") % pool.get_name())
>  
>      def _pool_apply(self):
> 

Thanks, pushed now

- Cole




More information about the virt-tools-list mailing list