[virt-tools-list] [virt-viewer 0/5] Preparing the ground for UI changes

Pavel Grunt pgrunt at redhat.com
Wed Jun 15 12:42:00 UTC 2016


Hi,

On Tue, 2016-06-14 at 23:40 +0200, Fabiano Fidêncio wrote:
> These small series has as objective start "preparing the ground" for
> the work Sagar Huge has been done on re-design/re-write virt-viewer's
> UI in a way to have it looking as something from this decade. :-) [0]

I really like the new UI.
> 
> There is still a lot of work to do on our (Sagar's and mine) side and
> once they are fixed he will send the patches and ask for comments and
> reviews. So far I'm keeping his patches rebased on top of current
> master on my personal gitlab[1] and you also can find his work on his
> personal's github[2].
> 
> As I said, there's still a lot of work to do and we are trying to do it
> as soon as possible. Our target is to have it in for Fedora25 and maybe
> we will need a virt-viewer release before starting, actually, doing the
> UI changes (for those who want to stick to the old UI/not bump GLib/Gtk
> dependencies' versions).
F25 sounds like a reasonable goal

> 
> This small series of patch can also be found on another branch of my
> personal gitlab repo[3] and can be waiting there till we have SLES 12
> SP2 release, as the 3rd patch of this series will bump GLib dependency
> version, making impossible to build virt-viewer in a stock SLES 12 SP1.

I don't think it is reasonable to wait for SLES to be released. As you said a
release can be done before merging Sagar's and yours works upstream.

Pavel

> 
> Unfortunately I still didn't have time to rebase Sagar's patch on top
> of this series, but it will be done soon (hopefully).
> 
> [0]: https://fidencio.fedorapeople.org/Sagar/
> [1]: https://gitlab.com/fidencio/virt-viewer/tree/sagar/wip/headerbar
> [2]: https://github.com/sagarghuge/virt-viewer/tree/headerbar
> [3]: https://gitlab.com/fidencio/virt-viewer/tree/wip/headerbar
> 
> Fabiano Fidêncio (5):
>   remote-viewer: Add missing chain-up to parent's window_added() method
>   remote-viewer: Remove unneeded g_application_hold() call
>   app: Set the resource base path
>   ui: Rename UI files to .ui (instead of .xml)
>   ui: Move ui files to $(srcdir)/resources/ui
> 
>  configure.ac                                  |   4 +-
>  po/POTFILES.in                                |  14 +-
>  src/Makefile.am                               |  20 +-
>  src/remote-viewer-connect.c                   |   2 +-
>  src/remote-viewer-connect.xml                 | 152 ---------------
>  src/remote-viewer.c                           |   2 +
>  src/resources/ui/remote-viewer-connect.ui     | 152 +++++++++++++++
>  src/resources/ui/virt-viewer-about.ui         |  66 +++++++
>  src/resources/ui/virt-viewer-auth.ui          | 160 ++++++++++++++++
>  src/resources/ui/virt-viewer-guest-details.ui | 120 ++++++++++++
>  src/resources/ui/virt-viewer-preferences.ui   | 134 ++++++++++++++
>  src/resources/ui/virt-viewer-vm-connection.ui | 117 ++++++++++++
>  src/resources/ui/virt-viewer.ui               | 256
> ++++++++++++++++++++++++++
>  src/resources/virt-viewer.gresource.xml       |  19 ++
>  src/virt-viewer-about.xml                     |  66 -------
>  src/virt-viewer-app.c                         |   6 +-
>  src/virt-viewer-auth.c                        |   2 +-
>  src/virt-viewer-auth.xml                      | 160 ----------------
>  src/virt-viewer-guest-details.xml             | 120 ------------
>  src/virt-viewer-preferences.xml               | 134 --------------
>  src/virt-viewer-util.h                        |   2 +-
>  src/virt-viewer-vm-connection.c               |   2 +-
>  src/virt-viewer-vm-connection.xml             | 117 ------------
>  src/virt-viewer-window.c                      |   6 +-
>  src/virt-viewer.gresource.xml                 |  19 --
>  src/virt-viewer.xml                           | 256 -----------------------
> ---
>  26 files changed, 1055 insertions(+), 1053 deletions(-)
>  delete mode 100644 src/remote-viewer-connect.xml
>  create mode 100644 src/resources/ui/remote-viewer-connect.ui
>  create mode 100644 src/resources/ui/virt-viewer-about.ui
>  create mode 100644 src/resources/ui/virt-viewer-auth.ui
>  create mode 100644 src/resources/ui/virt-viewer-guest-details.ui
>  create mode 100644 src/resources/ui/virt-viewer-preferences.ui
>  create mode 100644 src/resources/ui/virt-viewer-vm-connection.ui
>  create mode 100644 src/resources/ui/virt-viewer.ui
>  create mode 100644 src/resources/virt-viewer.gresource.xml
>  delete mode 100644 src/virt-viewer-about.xml
>  delete mode 100644 src/virt-viewer-auth.xml
>  delete mode 100644 src/virt-viewer-guest-details.xml
>  delete mode 100644 src/virt-viewer-preferences.xml
>  delete mode 100644 src/virt-viewer-vm-connection.xml
>  delete mode 100644 src/virt-viewer.gresource.xml
>  delete mode 100644 src/virt-viewer.xml
> 




More information about the virt-tools-list mailing list