[virt-tools-list] [virt-viewer 1/5] remote-viewer: Add missing chain-up to parent's window_added() method

Jonathon Jongsma jjongsma at redhat.com
Fri Jun 17 21:45:54 UTC 2016


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Tue, 2016-06-14 at 23:40 +0200, Fabiano Fidêncio wrote:
> It hasn't bitten us so far but would from the moment we add support to
> app-menu/headerbar.
> 
> By not chaining-up to the parent's method, gtk_window_set_application()
> hasn't been called, which ends up, due to a explicit check (in
> GtkWindow::realize() method) for a GtkApplication object associated to
> the GtkWindow object, not being able to load the app-menu and then
> using the "fallback" app-menu, which only contains the "Quit" item.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
>  src/remote-viewer.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/remote-viewer.c b/src/remote-viewer.c
> index 11b51e9..71723cf 100644
> --- a/src/remote-viewer.c
> +++ b/src/remote-viewer.c
> @@ -627,6 +627,8 @@ remote_viewer_window_added(GtkApplication *app,
>                                  g_object_get_data(G_OBJECT(w), "virt-viewer-
> window"));
>      spice_menu_update(REMOTE_VIEWER(app), win);
>      spice_foreign_menu_update(REMOTE_VIEWER(app), win);
> +
> +    GTK_APPLICATION_CLASS(remote_viewer_parent_class)->window_added(app, w);
>  }
>  #endif
>  




More information about the virt-tools-list mailing list