[virt-tools-list] [PATCH virt-viewer 2/2 v2] package: Add appdata metadata for Gnome Software

Daniel P. Berrange berrange at redhat.com
Fri Jun 24 09:57:13 UTC 2016


On Fri, Jun 24, 2016 at 11:45:13AM +0200, Lukáš Venhoda wrote:
> Adds metadata to be used with Gnome Software.
> Includes name, summary, description and three screenshots of remote-viewer.
> ---
> Changes since v1:
>  - typo
>  - removed line from commit log
>  - fixed website url
> ---
>  data/Makefile.am                  |  9 +++++++--
>  data/remote-viewer.appdata.xml.in | 28 ++++++++++++++++++++++++++++
>  po/POTFILES.in                    |  1 +
>  virt-viewer.spec.in               |  1 +
>  4 files changed, 37 insertions(+), 2 deletions(-)
>  create mode 100644 data/remote-viewer.appdata.xml.in
> 
> diff --git a/data/Makefile.am b/data/Makefile.am
> index 821c171..55718d9 100644
> --- a/data/Makefile.am
> +++ b/data/Makefile.am
> @@ -76,6 +76,11 @@ mimedir = $(datadir)/mime/packages
>  mime_DATA = virt-viewer-mime.xml
>  @INTLTOOL_XML_RULE@
> 
> +appdatadir       = $(datadir)/appdata
> +APPDATAFILES     = remote-viewer.appdata.xml.in
> +appdata_DATA     = $(APPDATAFILES:.xml.in=.xml)
> + at INTLTOOL_XML_RULE@
> +
>  install-data-hook:
>  if ENABLE_UPDATE_MIMEDB
>  	@if $(AM_V_P); then set -x; else echo "  INSTALL  update-mime-database"; fi; \
> @@ -88,8 +93,8 @@ if ENABLE_UPDATE_MIMEDB
>  	$(UPDATE_MIME_DATABASE) "$(DESTDIR)$(datadir)/mime";
>  endif
> 
> -CLEANFILES += $(mime_DATA) $(desktop_DATA)
> -EXTRA_DIST += $(MIMEFILES) $(DESKTOPFILES)
> +CLEANFILES += $(mime_DATA) $(desktop_DATA) $(appdata_DATA)
> +EXTRA_DIST += $(MIMEFILES) $(DESKTOPFILES) $(APPDATAFILES)
> 
>  endif
> 
> diff --git a/data/remote-viewer.appdata.xml.in b/data/remote-viewer.appdata.xml.in
> new file mode 100644
> index 0000000..1fa9d31
> --- /dev/null
> +++ b/data/remote-viewer.appdata.xml.in
> @@ -0,0 +1,28 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<application>
> + <id type="desktop">remote-viewer.desktop</id>
> + <metadata_license>CC0-1.0</metadata_license>
> + <project_license>GPL-2.0+</project_license>
> + <_name>Remote Viewer</_name>
> + <_summary>Remotely access virtual machines</_summary>
> + <description>
> +  <_p>
> +    Remote Viewer provides a graphical viewer for the guest OS
> +    display. At this time it supports guest OS using the VNC
> +    or SPICE protocols. Further protocols may be supported in
> +    the future as user demand dictates. The viewer can connect
> +    directly to both local and remotely hosted guest OS, optionally
> +    using SSL/TLS encryption.
> +  </_p>
> + </description>
> + <screenshots>
> +  <screenshot type="default">http://www.spice-space.org/static/images/remote_viewer_youtube.png</screenshot>
> +  <screenshot>http://www.spice-space.org/static/images/remote_viewer_usbredir.png</screenshot>
> +  <screenshot>http://www.spice-space.org/static/images/remote_viewer_shared_folder.png</screenshot>
> + </screenshots>
> + <provides>
> +  <binary>virt-viewer</binary>
> + </provides>
> + <url type="homepage">https://virt-manager.org/</url>
> + <updatecontact>virt-tools-list_at_redhat.com</updatecontact>
> +</application>

If we're going todo this, then we should host the screenshots on the
actual project website, ie virt-manager.org, not spice-space.org.
Also we must ensure we use a URL path we will be willing to keep
stable indefinitely.

eg something like this

  http://virt-manager.org/appdata/en_US/screenshots/virt-viewer.png


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the virt-tools-list mailing list