[virt-tools-list] [virt-viewer v2 1/4] timed-revealer: Fix "revealer" refcounting

[Christophe Fergeau]

Hey, if you want to add Pavel's backtrace to one of the commit logs, I
think it was pointing at this g_clear_object line, so you could add it
the the log here.

Christophe

On Tue, Jun 28, 2016 at 05:22:59PM +0200, Fabiano Fidêncio wrote:
> From: Christophe Fergeau <cfergeau at redhat.com>
> 
> virt_viewer_timed_revealer_new calls gtk_container_add on the instance
> returned by gtk_revealer_new so VirtViewerTimedRevealer does not own any
> ref on this GtkRevealer instance. Unrefing it in _dispose() is thus wrong.
> ---
>  src/virt-viewer-timed-revealer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/virt-viewer-timed-revealer.c b/src/virt-viewer-timed-revealer.c
> index 9124dad..cad9ede 100644
> --- a/src/virt-viewer-timed-revealer.c
> +++ b/src/virt-viewer-timed-revealer.c
> @@ -126,7 +126,7 @@ virt_viewer_timed_revealer_dispose(GObject *object)
>      VirtViewerTimedRevealerPrivate *priv = self->priv;
>  
>      g_clear_object(&priv->evBox);
> -    g_clear_object(&priv->revealer);
> +    priv->revealer = NULL;
>  
>      if (priv->timeout_id) {
>          g_source_remove(priv->timeout_id);
> -- 
> 2.7.4
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20160628/7b5d54f5/attachment.sig>