[virt-tools-list] [PATCH v2 virt-viewer] Get rid of deprecated functions to customize widget colors

Pavel Grunt pgrunt at redhat.com
Wed Jun 29 13:41:25 UTC 2016


On Wed, 2016-06-29 at 10:24 -0300, Eduardo Lima (Etrunko) wrote:
> On 06/29/2016 05:08 AM, Pavel Grunt wrote:
> > 
> > Hi,
> > 
> > Imo the commit message should say that there are issues with the font /
> > background colour since commit ... in some gtk versions - like you said in
> > the
> > comment for v1, because that is the reason for this patch. Getting rid of
> > deprecated functions is a "side effect".
> > 
> 
> Well, if you notice the previous email, the message was after the line
> starting with '---' meaning it would be ignored. 

yeah, I called it "comment", not sure if it is the correct term

> I wanted to explain why
> I was doing it only for 3.20 and thought it would not matter in the
> commit message. Anyway, I will add more information to the commit
> message and push it.
> 
ok

Pavel




More information about the virt-tools-list mailing list