[virt-tools-list] [virt-viewer] ovirt: Only use active ISO domains for foreign menu

[Eduardo Lima (Etrunko)]

On 03/01/2016 10:36 AM, Christophe Fergeau wrote:
> oVirt storage domains can be in various states (inactive, in
> maintainance, ...). We only want to show the ISOs it contains in the
> foreign menu when the storage domain is actually active, not in the
> other states.
> ---
>  src/ovirt-foreign-menu.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
> index 9859439..82f0f2a 100644
> --- a/src/ovirt-foreign-menu.c
> +++ b/src/ovirt-foreign-menu.c
> @@ -650,12 +650,17 @@ static void storage_domains_fetched_cb(GObject *source_object,
>      while (g_hash_table_iter_next(&iter, NULL, (gpointer *)&domain)) {
>          OvirtCollection *file_collection;
>          int type;
> +        int state;
>  
> -        g_object_get(domain, "type", &type, NULL);
> +        g_object_get(domain, "type", &type, "state", &state, NULL);
>          if (type != OVIRT_STORAGE_DOMAIN_TYPE_ISO) {
>              continue;
>          }
>  
> +        if (state != OVIRT_STORAGE_DOMAIN_STATE_ACTIVE) {
> +            continue;
> +        }
> +

Maybe put this test together with the previous one with || ?

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com