[virt-tools-list] [virt-viewer] Use GResource for loading ui files

[Eduardo Lima (Etrunko)]

On 02/29/2016 03:01 PM, Fabiano Fidêncio wrote:
> On Mon, Feb 29, 2016 at 6:27 PM, Eduardo Lima (Etrunko)
> <etrunko at redhat.com> wrote:
>> On 02/26/2016 07:38 PM, Fabiano Fidêncio wrote:
>>> Let's take advantage of GResource for loading ui files in a better and
>>> cleaner way than virt_viewer_util_load_ui() was doing.
>>> It also brings the benefit, at least for developers, of being able to
>>> test ui changes without having to "make install" virt-viewer.
>>>
>>
>> General question, does this mean that those XML files don't need to be
>> installed anymore?
> 
> Yes, they end up compiled right into the executable..
> 
>> If so, you might also remove them from Makefile.
> 
> We still have to distribute them.
> 

Yes, wee need to distribute, but no need to install them during make
install.

Just replace builderxml_DATA with noinst_DATA and remove builderxmldir.


>
>> Otherwise patch looks good. I don't kwnow much about GResources, so it
>> might be interesting to listen from more experienced people.
> 
> Thanks for the review.
> 


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com