[virt-tools-list] [virt-viewer v2] ovirt: Only use active ISO domains for foreign menu

Eduardo Lima (Etrunko) etrunko at redhat.com
Wed Mar 2 13:08:06 UTC 2016


On 03/02/2016 09:04 AM, Fabiano Fidêncio wrote:
> On Wed, Mar 2, 2016 at 12:02 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> On Wed, Mar 02, 2016 at 08:52:28AM +0100, Christophe Fergeau wrote:
>>> oVirt storage domains can be in various states (inactive, in
>>> maintainance, ...). We only want to show the ISOs it contains in the
>>> foreign menu when the storage domain is actually active, not in the
>>> other states.
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1310450
>>> ---
>>> Changes since v1:
>>>      - added new condition to an existing if() block
>>
>> Fwiw, I prefer the v1 way which I find much easier to read.
> 
> Same here.

V1 it is then :)

Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list