[virt-tools-list] [PATCH virt-viewer 0/3] Add tests for monitor mapping

[Fabiano Fidêncio]

Pavel,

On Tue, Mar 8, 2016 at 9:20 AM, Pavel Grunt <pgrunt at redhat.com> wrote:
> Hello,
>
> these patches move virt_viewer_app_parse_monitor_mappings from virt-viewer-app
> to virt-viewer-util. Parsing monitor mapping has no dependency on VirtViewerApp.
> And thanks to the move to the util, it is possible to add tests for this area,
> because it was tested only manually - by editting the config file and connecting
> to a vm, so some cases where not covered:
>  rhbz#1315206
>  rhbz#1304648

++ for adding tests for multimonitors' config files.
I have a few comments, you can find them in the reviews of the specific patches.

Tests for the vv file would be more than welcome as well, but that's
something for the future :-)

>
> Pavel Grunt (3):
>   Move monitor mapping parsing from app to util
>   virt_viewer_parse_monitor_mappings: Add parameter for client monitors
>   test: Add tests for monitor mapping
>
>  src/Makefile.am            |  30 +++++++++---
>  src/test-monitor-mapping.c | 119 +++++++++++++++++++++++++++++++++++++++++++++
>  src/virt-viewer-app.c      |  82 +------------------------------
>  src/virt-viewer-util.c     |  87 +++++++++++++++++++++++++++++++++
>  src/virt-viewer-util.h     |   4 ++
>  5 files changed, 236 insertions(+), 86 deletions(-)
>  create mode 100644 src/test-monitor-mapping.c
>
> --
> 2.5.0
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Best Regards,