[virt-tools-list] [PATCH v2 virt-viewer 2/2] configure: cleanup {GLIB2, GTK}_CFLAGS

[Pavel Grunt]

Hi Eduardo,

On Tue, 2016-03-22 at 11:45 -0300, Eduardo Lima (Etrunko) wrote:
> Also, remove unecessary AC_SUBST calls, as {GLIB2,GTK}_LIBS are never
> touched.

thanks
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  configure.ac | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 115ad81..4f7087e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -102,10 +102,9 @@ GLIB_MKENUMS=`$PKG_CONFIG --
> variable=glib_mkenums glib-2.0`
>  AC_SUBST(GLIB_MKENUMS)
>  
>  PKG_CHECK_MODULES(GLIB2, glib-2.0 >= $GLIB2_REQUIRED gio-2.0
> gthread-2.0 gmodule-export-2.0)
> -GLIB2_CFLAGS="$GLIB2_CFLAGS
> -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION"
> -GLIB2_CFLAGS="$GLIB2_CFLAGS
> -DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION"
> +GLIB2_CFLAGS="$GLIB2_CFLAGS
> -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION \
> +    -DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION"
my personal preference would be to keep the old variant, because it is
more readable for me.

ack

Pavel
>  AC_SUBST(GLIB2_CFLAGS)
> -AC_SUBST(GLIB2_LIBS)
>  
>  AC_ARG_VAR([GLIB_COMPILE_RESOURCES],[the glib-compile-resources
> program])
>  AC_PATH_PROG([GLIB_COMPILE_RESOURCES],[glib-compile-resources],[])
> @@ -137,10 +136,9 @@ AC_CHECK_LIB([virt],
>  LIBS=$old_LIBS
>  
>  PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED)
> -GTK_CFLAGS="$GTK_CFLAGS
> -DGDK_VERSION_MIN_REQUIRED=$GTK_ENCODED_VERSION"
> -GTK_CFLAGS="$GTK_CFLAGS
> -DGDK_VERSION_MAX_ALLOWED=$GTK_ENCODED_VERSION"
> +GTK_CFLAGS="$GTK_CFLAGS
> -DGDK_VERSION_MIN_REQUIRED=$GTK_ENCODED_VERSION \
> +    -DGDK_VERSION_MAX_ALLOWED=$GTK_ENCODED_VERSION"
>  AC_SUBST(GTK_CFLAGS)
> -AC_SUBST(GTK_LIBS)
>  
>  AC_ARG_WITH([gtk-vnc],
>      AS_HELP_STRING([--without-gtk-vnc], [Ignore presence of gtk-vnc
> and disable it]))