[virt-tools-list] [PATCH virt-viewer] Add some missing mnemonics to menu items

[Jonathon Jongsma]

On Wed, 2016-05-04 at 11:09 +0200, Pavel Grunt wrote:
> On Wed, 2016-05-04 at 05:00 -0400, Frediano Ziglio wrote:
> > > 
> > > 
> > > Hi Jonathon,
> > > 
> > > On Tue, 2016-05-03 at 15:48 -0500, Jonathon Jongsma wrote:
> > > > Fixes: rhbz#1332545
> > > 
> > > Acked-by: Pavel Grunt <pgrunt at redhat.com>
> > > 
> > > Thanks,
> > > Pavel
> > > 
> > 
> > I though mnemonic mean something different. Aren't we adding some
> > kind of keyboard shortcut?
> > 
> > Frediano
> 
> It means keyboard accelerator. It is for navigation in menus (eg you press
> Alt+V
> - it opens the View menu, then press Z, it opens the zoom submenu, then I and
> it
> changes zoom)
> 
> Pavel


Yes, GTK+ calls these mnemonics: https://developer.gnome.org/gtk3/unstable/GtkLa
bel.html#gtk-label-set-markup-with-mnemonic


> 
> > 
> > 
> > > > ---
> > > >  src/virt-viewer.xml | 10 +++++-----
> > > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > > > 
> > > > diff --git a/src/virt-viewer.xml b/src/virt-viewer.xml
> > > > index 52c6c93..830a451 100644
> > > > --- a/src/virt-viewer.xml
> > > > +++ b/src/virt-viewer.xml
> > > > @@ -32,7 +32,7 @@
> > > >                          <property name="visible">True</property>
> > > >                          <property name="can_focus">False</property>
> > > >                          <property
> > > > name="use_action_appearance">False</property>
> > > > -                        <property name="label"
> > > > translatable="yes">Screenshot</property>
> > > > +                        <property name="label"
> > > > translatable="yes">_Screenshot</property>
> > > >                          <property name="use_underline">True</property>
> > > >                          <signal name="activate"
> > > > handler="virt_viewer_window_menu_file_screenshot" swapped="no"/>
> > > >                        </object>
> > > > @@ -43,7 +43,7 @@
> > > >                          <property name="sensitive">False</property>
> > > >                          <property name="can_focus">False</property>
> > > >                          <property
> > > > name="use_action_appearance">False</property>
> > > > -                        <property name="label" translatable="yes">USB
> > > > device
> > > > selection</property>
> > > > +                        <property name="label" translatable="yes">_USB
> > > > device
> > > > selection</property>
> > > >                          <property name="use_underline">True</property>
> > > >                          <signal name="activate"
> > > > handler="virt_viewer_window_menu_file_usb_device_selection"
> > > > swapped="no"/>
> > > >                        </object>
> > > > @@ -72,7 +72,7 @@
> > > >                        <object class="GtkMenuItem" id="menu
> > > > -preferences">
> > > >                          <property name="visible">True</property>
> > > >                          <property name="can_focus">False</property>
> > > > -                        <property name="label"
> > > > translatable="yes">Preferences</property>
> > > > +                        <property name="label"
> > > > translatable="yes">_Preferences</property>
> > > >                          <property name="use_underline">True</property>
> > > >                          <signal name="activate"
> > > > handler="virt_viewer_window_menu_preferences_cb" swapped="no"/>
> > > >                        </object>
> > > > @@ -116,7 +116,7 @@
> > > >                          <property name="can_focus">False</property>
> > > >                          <property
> > > > name="use_action_appearance">False</property>
> > > >                          <property name="accel_path"><virt-
> > > > viewer>/view/toggle-fullscreen</property>
> > > > -                        <property name="label" translatable="yes">Full
> > > > screen</property>
> > > > +                        <property name="label" translatable="yes">_Full
> > > > screen</property>
> > > >                          <property name="use_underline">True</property>
> > > >                          <signal name="toggled"
> > > > handler="virt_viewer_window_menu_view_fullscreen" swapped="no"/>
> > > >                        </object>
> > > > @@ -181,7 +181,7 @@
> > > >                          <property name="visible">True</property>
> > > >                          <property name="can_focus">False</property>
> > > >                          <property
> > > > name="use_action_appearance">False</property>
> > > > -                        <property name="label"
> > > > translatable="yes">Displays</property>
> > > > +                        <property name="label"
> > > > translatable="yes">_Displays</property>
> > > >                          <property name="use_underline">True</property>
> > > >                        </object>
> > > >                      </child>
> > > 
> > > _______________________________________________
> > > virt-tools-list mailing list
> > > virt-tools-list at redhat.com
> > > https://www.redhat.com/mailman/listinfo/virt-tools-list