[virt-tools-list] [PATCH virt-install 1/2] Append '--attach' to virt-viewer for local display if spice gl enabled.

Cole Robinson crobinso at redhat.com
Sat May 7 23:29:45 UTC 2016


On 05/04/2016 05:33 AM, Lin Ma wrote:
> Currently SPICE GL support is local-only, So it needs to attach to the
> local display.
> 
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  virtinst/cli.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/virtinst/cli.py b/virtinst/cli.py
> index 8a3f6ae..cff1245 100644
> --- a/virtinst/cli.py
> +++ b/virtinst/cli.py
> @@ -423,6 +423,11 @@ def _gfx_console(guest):
>              "--connect", guest.conn.uri,
>              "--wait", guest.name]
>  
> +    # Currently virt-viewer needs attaching to the local display while
> +    # spice gl is enabled.
> +    if guest.has_gl():
> +        args.append("--attach")
> +
>      logging.debug("Launching virt-viewer for graphics type '%s'",
>          guest.get_devices("graphics")[0].type)
>      return _run_console(args)
> 

Thanks, pushed now

- Cole




More information about the virt-tools-list mailing list