[virt-tools-list] [virt-bootstrap] [PATCH v6 23/26] Show warning for unprivileged users

[Cedric Bosdonnat]

On Thu, 2017-08-17 at 10:40 +0100, Radostin Stoyanov wrote:
> Show warning message and don't allow ownership mapping for non-root
> user when the output format is 'dir'.
> ---
>  src/virtBootstrap/virt_bootstrap.py | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/virtBootstrap/virt_bootstrap.py b/src/virtBootstrap/virt_bootstrap.py
> index 59a340c..57ff140 100755
> --- a/src/virtBootstrap/virt_bootstrap.py
> +++ b/src/virtBootstrap/virt_bootstrap.py
> @@ -109,6 +109,13 @@ def bootstrap(uri, dest,
>      """
>      Get source object and call unpack method
>      """
> +    if fmt == 'dir' and os.geteuid() != 0:
> +        if uid_map or gid_map:
> +            raise ValueError("UID/GID mapping with 'dir' format is "
> +                             "allowed only for root.")
> +        logger.warning("All extracted files will be owned by the current "
> +                       "unprivileged user.")
> +
>      # Get instance of progress storing module
>      prog = progress.Progress(progress_cb)
>  
ACK

--
Cedric