[virt-tools-list] [virt-bootstrap] [PATCH v7 11/26] UID/GID mapping: Use empty list instead of None

Cedric Bosdonnat cbosdonnat at suse.com
Tue Aug 29 07:41:12 UTC 2017


On Sat, 2017-08-26 at 21:42 +0100, Radostin Stoyanov wrote:
> Resove an issue when only uid_map or only gid_map is specified.
> 

Typo still here: s/Resove/Resolve/

ACK with this fixed

--
Cedric

> We set the default values to None. However, `len(None)` will raise
> an exception. To avoid this we need to set the default values to
> [] (empty list).
> ---
>  src/virtBootstrap/virt_bootstrap.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/virtBootstrap/virt_bootstrap.py b/src/virtBootstrap/virt_bootstrap.py
> index 0bc2e2b..f970838 100755
> --- a/src/virtBootstrap/virt_bootstrap.py
> +++ b/src/virtBootstrap/virt_bootstrap.py
> @@ -120,6 +120,12 @@ def bootstrap(uri, dest,
>          logger.error("No write permissions on destination path '%s'", dest)
>          sys.exit(1)
>  
> +    if uid_map is None:
> +        uid_map = []
> +
> +    if gid_map is None:
> +        gid_map = []
> +
>      source(uri=uri,
>             fmt=fmt,
>             username=username,




More information about the virt-tools-list mailing list