[virt-tools-list] [virt-bootstrap] [PATCH v7 13/26] Simplify setting permissins of shadow file

Cedric Bosdonnat cbosdonnat at suse.com
Tue Aug 29 07:42:01 UTC 2017


typo in the commit title: s/permisssins/permissions/

ACK with this fixed
--
Cedric

On Sat, 2017-08-26 at 21:42 +0100, Radostin Stoyanov wrote:
> ---
>  src/virtBootstrap/utils.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/virtBootstrap/utils.py b/src/virtBootstrap/utils.py
> index ea650fb..be9133c 100644
> --- a/src/virtBootstrap/utils.py
> +++ b/src/virtBootstrap/utils.py
> @@ -387,8 +387,7 @@ def set_root_password_in_rootfs(rootfs, password):
>  
>      shadow_file_permissions = os.stat(shadow_file)[0]
>      # Set read-write permissions to shadow file
> -    # 438 = 0110110110 = -rw-rw-rw-
> -    os.chmod(shadow_file, 438)
> +    os.chmod(shadow_file, 0o666)
>      try:
>          with open(shadow_file) as orig_file:
>              shadow_content = orig_file.read().split('\n')




More information about the virt-tools-list mailing list