[virt-tools-list] [PATCH] addhardware: Remove IDE from list while adding controllers
Cole Robinson
crobinso at redhat.com
Wed Dec 20 18:17:11 UTC 2017
On 11/22/2017 09:58 PM, Lin Ma wrote:
> Libvirt only supports built-in IDE controller so far, There is no
> any case that needs us manually add an IDE controller, So remove
> it from the controller list.
>
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
> virtManager/addhardware.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py
> index e563fe6..84bebec 100644
> --- a/virtManager/addhardware.py
> +++ b/virtManager/addhardware.py
> @@ -886,7 +886,8 @@ class vmmAddHardware(vmmGObjectUI):
> model.clear()
>
> for t in VirtualController.TYPES:
> - if t == VirtualController.TYPE_PCI:
> + if (t == VirtualController.TYPE_PCI or
> + t == VirtualController.TYPE_IDE):
> continue
> model.append([t, VirtualController.pretty_type(t)])
>
>
ACK and pushed with some formatting changes (using 'in [...]' instead of
string comparisons
Thanks,
Cole
More information about the virt-tools-list
mailing list