[virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

[Eduardo Lima (Etrunko)]

On 16/02/17 20:57, Daniel P. Berrange wrote:
> On Thu, Feb 16, 2017 at 11:05:13AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 16/02/17 10:06, Pavel Grunt wrote:
>>> Hi,
>>>
>>> On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote:
>>>> This whole series is the result of the initial idea of having the
>>>> new
>>>> iso-dialog to use this widget. Having it done only for the iso-
>>>> dialog
>>>> would not make much sense, so I went on and ported all other
>>>> dialogs.
>>>> The widget requires Gtk version 3.12, which should not be a problem
>>>> for
>>>> any recent distro.
>>>>
>>>> Using GtkHeaderBar makes dialogs look cleaner and more 'modern',
>>>> also
>>>> follow the style used by GNOME applications. In the near future,
>>>> virt-viewer main window could also make use of it, as we recently
>>>> saw in
>>>> a series sent to this mailing list.
>>>
>>> so are we going for the GNOME style for all desktop envs ? In my
>>> opinion it does not look nice in Windows and Xfce - simply does not
>>> fit it in. iirc it was mentioned that there is a way to have both the
>>> classic and the GNOME look in the discussion about Sagar's patches few
>>> weeks ago..
>>
>> I have no idea of what it looks like in Windows, but it indeed looks
>> good in Linux environments. I tested in both GNOME and Enlightenment,
>> not sure about other DEs out there. As far as I remember, the discussion
>> on that other series was about the classic menu versus the buttons on
>> the header bar.
> 
> Please post some screenshots showing the before & after state of this
> on GNOME, Linux non-GNOME and Windows, so we can accurately evaluate
> what the change is.
> 
> Also, I tried to apply this series to test it myself, but it fails to
> apply to git master for some reason

You can try my github remote, branch dialogs

git remote add etrunko git://github.com/etrunko/virt-viewer

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com